refactor(shapefile_utils): pathlib compatibility, other improvements#1583
Merged
Merged
Conversation
* Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
Codecov Report
@@ Coverage Diff @@
## develop #1583 +/- ##
=======================================
Coverage 72.6% 72.6%
=======================================
Files 251 251
Lines 54423 54422 -1
=======================================
+ Hits 39542 39551 +9
+ Misses 14881 14871 -10
|
christianlangevin
approved these changes
Oct 13, 2022
jdhughes-dev
approved these changes
Oct 13, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…odflowpy#1583) * Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…odflowpy#1583) * Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…odflowpy#1583) * Allow write_gridlines_shapefile to write .prj file * Add test_write_gridlines_shapefile * Add remaining file missed from modflowpy#1563 for Mt3dms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does several things:
flopy.export.shapefile_utilscan be used with pathlib objectswrite_gridlines_shapefileto write .prj filetest_write_gridlines_shapefileMt3dms