refactor(vtk): use pathlib, corrections to docstrings#1603
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1603 +/- ##
=======================================
Coverage 72.7% 72.7%
=======================================
Files 251 251
Lines 54488 54485 -3
=======================================
- Hits 39650 39648 -2
+ Misses 14838 14837 -1
|
Contributor
Author
|
Thanks @jdhughes-usgs I've used more Also, the docstrings are adjusted to use |
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
* fixes for review; use os.PathLike instead of Path for docstring
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
* fixes for review; use os.PathLike instead of Path for docstring
wpbonelli
pushed a commit
that referenced
this pull request
Dec 14, 2022
* fixes for review; use os.PathLike instead of Path for docstring
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
* fixes for review; use os.PathLike instead of Path for docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is primarily focused with the vtk export module:
deprecateddirective with a link to the recommended method(s)binaryoption withcount_lines_in_filesince it wasn't used and does not make senseis_binary_fileand use it instead of "exists()" checks