Feat sim pathlib support#1712
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1712 +/- ##
=======================================
Coverage 71.9% 71.9%
=======================================
Files 253 253
Lines 55891 55890 -1
=======================================
+ Hits 40202 40205 +3
+ Misses 15689 15685 -4
|
mwtoews
approved these changes
Feb 13, 2023
Contributor
mwtoews
left a comment
mwtoews
left a comment
There was a problem hiding this comment.
This is a good start. And thanks for resolving the pip warning.
wpbonelli
approved these changes
Feb 13, 2023
| self._sim_path = os.path.join(os.getcwd(), path) | ||
| # ensure that _sim_path is absolute | ||
| path = Path(path) | ||
| self._sim_path = path.absolute() |
Member
There was a problem hiding this comment.
Maybe worth calling path.expanduser().absolute() to get tilde expansion too? Just an extra convenience. Could do this in a followup PR, supporting PathLike more broadly throughout flopy seems worthwhile
This was referenced Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add pathlib support for
flopy.mf6.MFSimulation, so that one can supply a pathlike object to thesim_wsargument. This also adds pip toetc/environment.ymlto avoid the warning that you get when creating a conda environment from this file (conda installs pip anyways after the warning).