docs: add deprecation policy to dev docs and release guide#1889
Merged
Conversation
* describe deprecation policy loosely following NEP 23 * fix some autotest names per pending deprecations
Codecov Report
@@ Coverage Diff @@
## develop #1889 +/- ##
=======================================
Coverage 72.2% 72.2%
=======================================
Files 257 257
Lines 56488 56488
=======================================
Hits 40836 40836
Misses 15652 15652 |
jdhughes-dev
approved these changes
Aug 1, 2023
Member
Author
|
Thanks @mwtoews would you suggest correcting anticipated removal version numbers, or removing/omitting them? Looks like numpy does not include them in their sample warning messages, I guess they are inherently a bit speculative. |
Contributor
|
Thanks, I see that only the version the feature was deprecated should be specified, but the exact removal version does not need to be specified. It is also not possible to accurately "guess" if the +2 versions from now would be (e.g.) 3.6.0 or 4.0.0. Lets leave the existing deprecation messages alone for now, but going forward only specify the version they were deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add deprecation guidelines after discussion with @langevin-usgs, @jdhughes-usgs, @mjreno. Followup to #1878.
DEVELOPER.mddocs/make_release.mdDEVELOPER.mdPRs applying deprecations introduced in version 3.3.5 or before: