fix(modelgrid): retain crs data from classic nam files#1904
Merged
jdhughes-dev merged 1 commit intoAug 10, 2023
Conversation
050b823 to
b0e2a19
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1904 +/- ##
=========================================
+ Coverage 72.2% 72.6% +0.3%
=========================================
Files 257 257
Lines 56488 56237 -251
=========================================
+ Hits 40836 40840 +4
+ Misses 15652 15397 -255
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug from #1737 where loading classic NAM files does not retain any CRS information that may be been stored in the header comment.
modelgridproperties.proj4and.epsgare generated from thecrsinputs..proj4retains the original string input to crs, and.epsgretains a valid integer parsed from the crs input.This PR adds tests for
flopy.utils.mfreadnam.attribs_from_namfile_headerand checks the same simulations withModflow.loadto inspect a few modelgrid properties. This PR was also tested locally without pyproj.