fix(resolve_exe): support extensionless abs/rel paths on windows#1957
Merged
Conversation
33df903 to
b24e38d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1957 +/- ##
=======================================
Coverage 72.6% 72.6%
=======================================
Files 257 257
Lines 57812 57818 +6
=======================================
+ Hits 42009 42029 +20
+ Misses 15803 15789 -14
|
Member
Author
|
after reconsidering the comment here
IMO this is more of a fix than a feature so we might wrap it into 3.4.3 (planned for this weekend) |
Member
Author
|
@langevin-usgs it would be good to get this into 3.4.3. CI will fail on develop after merging, but it shouldn't affect the release as bugfix commits will be cherry-picked |
christianlangevin
approved these changes
Sep 24, 2023
christianlangevin
left a comment
There was a problem hiding this comment.
Maybe this is end of this issue? Thanks, @wpbonelli.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation here is symmetry of portability — relative paths with
.exesuffix will work on non-Windows, and paths without.exesuffix will work on Windows, provided the relpath is otherwise identical