ci: remove branch filters from push trigger#1987
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1987 +/- ##
=======================================
Coverage 72.7% 72.7%
=======================================
Files 258 258
Lines 58829 58829
=======================================
Hits 42788 42788
Misses 16041 16041 |
christianlangevin
approved these changes
Oct 16, 2023
This was referenced Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always run commit-triggered workflows (
commit.yml,rtd.yml,mf6.yml) on push.This was suggested recently by @spaulins-usgs. CI testing work on a personal fork before opening a PR avoids consuming the upstream org's actions quota. To do this currently requires adding the branch name to the workflow's
on.push.branches, then removing it before the PR is merged. This is inconvenient and easily neglected.It seems safe to assume contributors generally want CI to run on their fork. To exclude a branch,
branches-ignorecan be used if needed.Existing branch filters are still kept for PR triggers.