refactor(lgrutil): coerce numpy types to builtins for np2 compat#2158
Merged
Conversation
christianlangevin
approved these changes
Apr 18, 2024
christianlangevin
left a comment
There was a problem hiding this comment.
This seems a bit surprising to me that we have to explicitly wrap numpy scalars with int and float, but glad you were able to implement a fix.
Member
Author
|
Numpy migration notes say this is expected for expressions where float32 is combined with the builtin float, this was the only one caught by a test but there are probably more cases where the change in promotion rules leads to slightly different results,. In general it may suffice to relax test comparisons but where we return non-numpy data structures (as here) it seems worth converting any np scalars to builtins for consistency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_lgrutil.pyfails with numpy>=2.0.0rc1float()to avoid loss of precision, per https://numpy.org/devdocs/numpy_2_0_migration_guide.html#changes-to-numpy-data-type-promotionlgr.get_exchange_data()