fix(mfdatascalar): skip multiple choice fields with default values#2712
Open
wpbonelli wants to merge 3 commits intomodflowpy:developfrom
Open
fix(mfdatascalar): skip multiple choice fields with default values#2712wpbonelli wants to merge 3 commits intomodflowpy:developfrom
wpbonelli wants to merge 3 commits intomodflowpy:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2712 +/- ##
===========================================
+ Coverage 55.5% 72.4% +16.9%
===========================================
Files 644 674 +30
Lines 124135 130572 +6437
===========================================
+ Hits 68947 94635 +25688
+ Misses 55188 35937 -19251
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When writing MF6 input files, don't write optional scalar variables whose values are equal to the defaults as specified in DFNs. This is a backwards-compatibility fix meant to keep new/breaking options from being written to input files when they are not explicitly used, so that new versions of flopy remain compatible with older versions of MF6.
This could cause significant differences in input files, but should not cause behavioral differences as MF6 implements the default values internally.
Introduce an option
write_defaultson the simulation, to allow opting into the old behavior. I figure it can still be useful as a kind of 'strict' mode.Fix #2710