Small improvements and bug fixes to support modflow2netcdf#4
Merged
Conversation
This was placing zeros in every cell even when there was no data for that cell. This now returns masked values in the cells where there is no data. I assumed that 0 could be an actual data value for some variables and that I couldn't strip out all 0s later on in the process.
christianlangevin
added a commit
that referenced
this pull request
Jan 8, 2015
Small improvements and bug fixes to support modflow2netcdf. For the cell by cell binary reader, if requesting full3d, then a masked array is returned. This seems to be generally beneficial, and may be a nice way to handle inactive and dry values in the heads as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please take a look at the create3D function that I changed. It was setting the entire array to 0 and then summing any values in that cell. I changed it to use and return a masked array. It was much easier for me to be able to assume a masked array and not have to strip out all zero values downstream in
modflow2netcdf. However, if you don't like the change, I can manage!