Skip to content

fix(setup.cfg): use 'find:' to include submodules; other tidying#102

Merged
jdhughes-dev merged 1 commit into
modflowpy:masterfrom
mwtoews:setuptools
Dec 3, 2021
Merged

fix(setup.cfg): use 'find:' to include submodules; other tidying#102
jdhughes-dev merged 1 commit into
modflowpy:masterfrom
mwtoews:setuptools

Conversation

@mwtoews
Copy link
Copy Markdown
Contributor

@mwtoews mwtoews commented Dec 3, 2021

This should fix the missing modules using the special find: directive described here. Also remove attr:, which only works for version, and remove sdist option, as it's probably not used here. I don't see the licence files, but this shouldn't matter.

The best way to build/check the package is using python -m build (which may required python -m pip install build, if not already there. And better from PyPI than conda for this tool, as it's written by PyPI).

Also update the installation documentation for presumably the stable version from PyPI.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2021

Codecov Report

Merging #102 (0c98d70) into master (154d139) will decrease coverage by 50.889%.
The diff coverage is n/a.

❗ Current head 0c98d70 differs from pull request most recent head 5955cab. Consider uploading reports for the commit 5955cab to get more accurate results

@@              Coverage Diff               @@
##            master      #102        +/-   ##
==============================================
- Coverage   65.919%   15.030%   -50.890%     
==============================================
  Files           16        16                
  Lines         4105      4105                
==============================================
- Hits          2706       617      -2089     
- Misses        1399      3488      +2089     
Impacted Files Coverage Δ
pymake/utils/_compiler_language_files.py 8.333% <0.000%> (-87.500%) ⬇️
pymake/pymake_base.py 2.732% <0.000%> (-84.290%) ⬇️
pymake/utils/_usgs_src_update.py 6.303% <0.000%> (-81.662%) ⬇️
pymake/utils/_compiler_switches.py 3.587% <0.000%> (-77.355%) ⬇️
pymake/pymake_build_apps.py 7.291% <0.000%> (-75.000%) ⬇️
pymake/utils/_Popen_wrapper.py 17.500% <0.000%> (-72.500%) ⬇️
pymake/utils/_dag.py 9.836% <0.000%> (-72.132%) ⬇️
pymake/plot/dependency_graphs.py 11.627% <0.000%> (-52.326%) ⬇️
pymake/pymake.py 23.364% <0.000%> (-51.714%) ⬇️
pymake/autotest/autotest.py 2.493% <0.000%> (-24.678%) ⬇️
... and 2 more

@jdhughes-dev
Copy link
Copy Markdown
Collaborator

Thanks for fixing this Mike.

@jdhughes-dev jdhughes-dev merged commit ec38029 into modflowpy:master Dec 3, 2021
@mwtoews mwtoews deleted the setuptools branch December 4, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants