Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the RadioList PHP control to improve label rendering by adding required class styling and including tooltip support for additional context.
- Introduces a modified label element with conditional "required" styling.
- Adds a new tooltip element with Bootstrap tooltip attributes and a FontAwesome icon.
Comment on lines
+149
to
+152
| $tooltip = $this->getTooltip() === null ?: Html::el('span') | ||
| ->title($this->getTooltip()) | ||
| ->addAttributes(['data-bs-placement' => 'top', 'data-bs-toggle' => 'tooltip']) | ||
| ->addHtml(\Kravcik\LatteFontAwesomeIcon\Extension::render('question-circle', color: 'blue')); |
There was a problem hiding this comment.
The tooltip assignment uses a boolean check with the Elvis operator. If getTooltip() returns null, it will set $tooltip to true rather than a tooltip element. Consider rewriting this conditional to properly assign an HTML element only when a non-null tooltip is available.
Suggested change
| $tooltip = $this->getTooltip() === null ?: Html::el('span') | |
| ->title($this->getTooltip()) | |
| ->addAttributes(['data-bs-placement' => 'top', 'data-bs-toggle' => 'tooltip']) | |
| ->addHtml(\Kravcik\LatteFontAwesomeIcon\Extension::render('question-circle', color: 'blue')); | |
| $tooltip = $this->getTooltip() !== null | |
| ? Html::el('span') | |
| ->title($this->getTooltip()) | |
| ->addAttributes(['data-bs-placement' => 'top', 'data-bs-toggle' => 'tooltip']) | |
| ->addHtml(\Kravcik\LatteFontAwesomeIcon\Extension::render('question-circle', color: 'blue')) | |
| : null; |
vodictomas
approved these changes
Jun 12, 2025
Collaborator
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.