Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR integrates reactive signal support into the RadioList control by invoking addSignalsToInput on each radio input.
- Injects signal attachments into rendered radio inputs.
- Maintains existing class assignments on the input element.
Comments suppressed due to low confidence (2)
src/control/RadioList.php:93
- New signal injection logic should have accompanying unit tests to verify that signals are correctly attached to each radio input during rendering.
$this->addSignalsToInput($input);
src/control/RadioList.php:93
- Calling
addSignalsToInputbefore the subsequentclass()call will overwrite any classes or attributes that the signal setup may add. Consider moving this call below theclass()invocation or merging classes to preserve both.
$this->addSignalsToInput($input);
kravcik
approved these changes
Jul 1, 2025
vodictomas
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.