Skip to content

#103 radioList add singals#104

Merged
kravcik merged 1 commit intomainfrom
main-#103
Jul 1, 2025
Merged

#103 radioList add singals#104
kravcik merged 1 commit intomainfrom
main-#103

Conversation

@KrejciFili
Copy link
Copy Markdown
Member

No description provided.

@KrejciFili KrejciFili requested a review from vodictomas July 1, 2025 11:16
@kravcik kravcik requested a review from Copilot July 1, 2025 11:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates reactive signal support into the RadioList control by invoking addSignalsToInput on each radio input.

  • Injects signal attachments into rendered radio inputs.
  • Maintains existing class assignments on the input element.
Comments suppressed due to low confidence (2)

src/control/RadioList.php:93

  • New signal injection logic should have accompanying unit tests to verify that signals are correctly attached to each radio input during rendering.
			$this->addSignalsToInput($input);

src/control/RadioList.php:93

  • Calling addSignalsToInput before the subsequent class() call will overwrite any classes or attributes that the signal setup may add. Consider moving this call below the class() invocation or merging classes to preserve both.
			$this->addSignalsToInput($input);

@kravcik kravcik self-requested a review July 1, 2025 11:39
@kravcik kravcik merged commit 3b82589 into main Jul 1, 2025
1 check passed
@kravcik kravcik deleted the main-#103 branch July 1, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants