Fixed SQL for "exclude" parameter#1
Merged
jpdevries merged 1 commit intomodxcms:developfrom Oct 2, 2013
jrotering:develop
Merged
Fixed SQL for "exclude" parameter#1jpdevries merged 1 commit intomodxcms:developfrom jrotering:develop
jpdevries merged 1 commit intomodxcms:developfrom
jrotering:develop
Conversation
IDs listed in the 'exclude' parameter were being put in a "NOT IN" clause, but not being removed from the "IN" clause. As a result those resources were not being properly excluded at least some of the time (not sure if this behavior was consistent across all environments). I don't know if something similar may need to be done in simplesearchdriversolr.class.php.
jpdevries
added a commit
that referenced
this pull request
Oct 2, 2013
Fixed SQL for "exclude" parameter
|
I don't think this should be merged. We should do clean up of the commented code inside. |
Author
There was a problem hiding this comment.
It is the line that used to build the "NOT IN" clause, commented out. I expected someone to remove 165-166 before merging this, but thought there was a remote possibility that the "NOT IN" was important in ways I didn't understand, so I left it as commented-out.
|
ok so this PR just comments out one line, and adds a comment. I can remove both of those lines can be removed before merging with production. @jrotering are there any specific tests that come to mind to ensure this works correctly and also doesn't introduce any new issues? |
matdave
pushed a commit
that referenced
this pull request
Jul 25, 2022
Adding option for boosting based on tvs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDs listed in the 'exclude' parameter were being put in a "NOT IN" clause, but not being removed from the "IN" clause. As a result those resources were not being properly excluded at least some of the time (not sure if this behavior was consistent across all environments).
I don't know if something similar may need to be done in simplesearchdriversolr.class.php.