Can't edit plugin configuration settings after upgrade

[Haprog]

The problem is trying to save any plugin after it has been upgraded to a newer version by upgrading MODX.

For example if you upgrade MODX to 1.0.13 from an older version so that it also upgrades TinyMCE, then you will have two plugins named "TinyMCE Rich Text Editor" but with different IDs and the older version will be disabled (grayed out). This wasn't a problem in 1.0.12 because the duplicate name check for saving plugins was just added in 1.0.13 in commit 79cc709

Current workaround: Delete or rename old versions of the plugin.

I think it's good that plugin/snippet/etc names are unique, so I suggest that the MODX upgrade process should be fixed to rename old plugins when upgrading (at the same point when they are disabled).

Maybe the old plugin should be renamed so that it's version number is appended to the plugin name? I think this is what MODX already does with snippets?

[Haprog]

This should probably be fixed by changing the behavior of install/instprocessor.php but I'm not sure what is the best way.

1. Just overwrite the old plugin (migrating old properties using propUpdate()) like snippet update seems to do.
2. Rename old plugin
3. Maybe something else?

I could probably fix this myself if we agree on how it should be done.

[Jako]

Plugins could have duplicate names but only one plugin should be active. This could be checked with an updated query.

[Jako]

Renaming during update is an option too.

[Haprog]

@Jako Thanks for your feedback.

I fixed this in the above pull request by updating plugin save logic so that it allows duplicate names for disabled plugins. Duplicate names among enabled plugins are still prevented. I tested this fix and it seemed to work ok.

Maybe the language string (that shows when trying to save enabled plugin with a name that is already in use by another enabled plugin) should also be updated now to better describe the situation when duplicates are allowed for disabled plugins but not for enabled plugins?

[Jako]

These strings should be moved to the language file too.

[Haprog]

The current strings used are already in the language file but this would require a new language string to better describe this situation.

I'm not sure what is the proper way to add or update language strings now that you also use Transifex for translation?

[Jako]

O.k. Remembered that wrong.

English -> by pull request.
Others -> by Transifex.

[Haprog]

I know how to translate existing strings using Transifex (I translated some to Finnish) but can I somehow get access to adding new strings there or what is the way to submit new language strings into the system? Or are they added automatically at some point based on the English language file?

Can I somehow generate the language files from Transifex myself?
Is there any documentation about working with evolution language strings?

I'll probably add a new string for this situation in the English language file and update this behaviour to use it and then submit a new pull request.

[Jako]

New strings in current english language files are automatic pulled from GitHub into Transifex. The files are watched.

[Haprog]

Ok. Thanks.

[Jako]

Don't know how often these are pulled – once a day I think.

[Haprog]

@Jako
I'd like to become a collaborator for evolution with push access if possible. Or at least work my way towards that.

In the mean while what is the preferred way to be in contact with you (other than posting on GitHub issues) if I want to discuss about improvements to MODX Evo and ask about how things should be done? I see there's an IRC channel but it doesn't seem to be very active. Do you maybe have some online meetings where people like me could join? Or should I just post on the forums?