Impr 981 - Invoke onDocPublish and onDocUnPublish events

[chucktrukk]

No description provided.

[yama]

Nice idea. I also agree to this.

[mkschell]

I definitely understand the logic here, but this actually conflicts with Jason's philosophy on the event and it's implementation in Revo. onDocPublished is meant to refer only to the menu-driven action. Plugins needing to respond to changes in publishing status during the Resource Save event need to listen to that event and see if the publish flag is changing, then take action. As far as the timed publishing goes, I think the possibility exists that if a very large number of resources are all triggered to publish or unpublish at the same time, it could cause a big performance problem, potentially causing the script to terminate mid-changes.
We may need to discuss further about what to do re: Evo. Regardless, it would be good to document some best practices.

[chucktrukk]

That doesnt make much sense.

It's not called 'rightclickOnDocPublish'. If it's only going to be OnPublish for 1 out of 3 possible events (timed, from edit, right-click), then it should either be removed or renamed (to rightClickOnDocPublish).

However, it is a great plugin point in the system. Here the system determines if the product has been updated, and fires the event. This is better than having all events be onUpdate and making us create our own methods to determine old/new status.

It should be ok that someone might have a bunch of plugins running onDocPublish and a large number of timed documents hit the plugin. That's what this onDocPublish is for.