Conversation
| EventCallBackRoute= /api/callbacks | ||
| AppBaseUri= %App Base Uri% | ||
| AppointmentReminderMenuAudio= /Audio/AppointmentReminderMenu.wav | ||
| # AddParticipantNumber= +918374734062 |
There was a problem hiding this comment.
remove commented code from all the files
| return CommunicationIdentifierKind.UNKNOWN | ||
| configuration_manager = ConfigurationManager.get_instance() | ||
| calling_Automation_client = CallAutomationClient.from_connection_string(configuration_manager.get_app_settings('Connectionstring')) | ||
| ngrok_url =configuration_manager.get_app_settings('AppBaseUri') |
There was a problem hiding this comment.
Rename this to app_base_uri
| SourcePhone=%SourcePhone% | ||
| SourcePhone=%Source Phone% | ||
| #<!-- Destination identities to call. Multiple outbound calls are seperated by a semi-colon and participants in an outbound call are seperated by a coma. | ||
| #For e.g. +14251002000, 8:acs:ab12b0ea-85ea-4f83-b0b6-84d90209c7c4_00000009-bce0-da09-54b7-xxxxxxxxxxxx; +14251002001, 8:acs:ab12b0ea-85ea-4f83-b0b6-84d90209c7c4_00000009-bce0-da09-555-xxxxxxxxxxxx). --> |
There was a problem hiding this comment.
remove this example, as we are not giving the identity like this in this sample
| Appointment_Cancelled_Audio,Timed_out_Audio,Invalid_Input_Audio): | ||
| self.connection_string: str = str(connection_string) | ||
| self.source_identity: str = str(source_identity) | ||
| self.source_phone_number: str = str(source_phone_number) |
There was a problem hiding this comment.
source_identy and source_phone_number are not the same? remove unused and extra variables
| from aiohttp import web | ||
| from Logger import Logger | ||
| from ConfigurationManager import ConfigurationManager | ||
| from CallConfiguration import CallConfiguration |
There was a problem hiding this comment.
do we need both ConfigurationManager and CallConfiguration both, use one
| # </summary> | ||
|
|
||
|
|
||
| async def on_incoming_request_async(self, request): |
| target_Id = self.configuration_manager.get_app_settings('TargetIdentity') | ||
|
|
||
| if(target_Id and len(target_Id)): | ||
| source_caller_id = CommunicationUserIdentifier(self.call_configuration.source_identity) |
There was a problem hiding this comment.
we are not using source_caller_id anywhere, remove this
| # web.run_app(self.app, port=8080) | ||
|
|
||
|
|
||
| def create_user(self, connection_string): |
There was a problem hiding this comment.
remove create and delete user methods too, if we are not using anywhere
| self.app.add_routes([web.get('/audio/{file_name}', self.load_file)]) | ||
| self.app.add_routes([web.post('/api/callbacks',self.start_callBack)]) | ||
| web.run_app(self.app, port=58963) | ||
| async def run_sample(self,request): |
There was a problem hiding this comment.
add some space b/w methods, to make the code more readable
|
Changes are done and committed the code. |
Change the name server to Call Automation
CallAutomation
2 participants
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information