Open
Conversation
v-mausha
requested changes
May 9, 2023
callautomation-Simple-IVR/program.py
Outdated
| from azure.communication.identity import CommunicationIdentityClient | ||
| from azure.communication.callautomation import CallAutomationClient,CallInvite,\ | ||
| CallAutomationEventParser,CallConnected,CallMediaRecognizeOptions,CallMediaRecognizeDtmfOptions,\ | ||
| CallConnectionClient,CallDisconnected,PlaySource,FileSource,ParticipantsUpdated,DtmfTone,\ |
callautomation-Simple-IVR/program.py
Outdated
| PlayOption = call_Connection_Media.play_to_all(playSource, operation_context='SimpleIVR') | ||
| elif toneDetected == DtmfTone.FOUR : | ||
| playSource = FileSource(uri=(BaseUri + configuration_manager.get_app_settings('AgentAudio'))) | ||
| PlayOption = call_Connection_Media.play_to_all(playSource, operation_context='AgentConnect') |
Collaborator
There was a problem hiding this comment.
playOption is not required,
also the PlaySource should be in the right format play_source
callautomation-Simple-IVR/program.py
Outdated
| if event.__class__ == PlayCompleted: | ||
|
|
||
| if event.operation_context == 'AgentConnect': | ||
| Participant_ToAdd = configuration_manager.get_app_settings('ParticipantToAdd') |
Collaborator
There was a problem hiding this comment.
variable name should follow the Snake Case, all letters should be in small, and words are seperated by '_'
callautomation-Simple-IVR/program.py
Outdated
| Callinvite=CallInvite(self.Participant_Add,sourceCallIdNumber=self.source_identity) | ||
|
|
||
| Logger.log_message(Logger.INFORMATION,'Performing add Participant operation') | ||
| self.Addparticipant_Response=call_Connection.add_participant(Callinvite) |
Collaborator
There was a problem hiding this comment.
here also follow the snake case, check everywhere
Collaborator
Author
There was a problem hiding this comment.
All changes are done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information