Release/v9.5.0#175
Merged
vgenev merged 40 commits intomojaloop:masterfrom Apr 15, 2020
Merged
Conversation
… the payeefsp can add participants
# Conflicts: # package-lock.json # package.json
… that logs aren't polluted on kubernetes
removed accept header on GET /payeefsp/parties/{type}/{id}
updated version to align with new sprint
# Conflicts: # package-lock.json # package.json
Updated dependencies Bump version Standard fixes
# Conflicts: # package-lock.json # package.json
# Conflicts: # package-lock.json # package.json
…op#126) added hapi to ncurc as version node version 10 isnt supported by latest version of hapi
* updated for logging times on the simulator for post transfers added hapi to ncurc as version node version 10 isnt supported by latest version of hapi * fix for end log of simulator not displaying
* updated for logging times on the simulator for post transfers added hapi to ncurc as version node version 10 isnt supported by latest version of hapi * fix for end log of simulator not displaying * added log statements to calculate sim time for put transfers
* updated for logging times on the simulator for post transfers added hapi to ncurc as version node version 10 isnt supported by latest version of hapi * fix for end log of simulator not displaying * added log statements to calculate sim time for put transfers * changed logging to errors * updated version * updated license
…tps://github.com/mojaloop/simulator into feature/#1140HostLoggingEnhancementOptimizations
mdebarros
requested changes
Apr 14, 2020
Member
mdebarros
left a comment
mdebarros
left a comment
There was a problem hiding this comment.
Hi, have a look at my comments.
Also if you are importing the latest logger library, also please ensure that you add the switch checks for each log statements.
I.e.
Logger.debug('hello world') --> Logger.isDebugEnabled && logger.debug('hello world')
I.e. use the is{{LOGLEVEL}Enabled functions as prefix enablers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.