Remove fixer, some PHPUnit non-static method calls were fixed to static calls#18
Open
shirshir wants to merge 1 commit intomollie:masterfrom
Open
Remove fixer, some PHPUnit non-static method calls were fixed to static calls#18shirshir wants to merge 1 commit intomollie:masterfrom
shirshir wants to merge 1 commit intomollie:masterfrom
Conversation
…ic calls For instance `$this->once()` to `self::once()`
Contributor
|
I have two questions:
|
Contributor
|
Is this related to different expectation/assumptions on PHPUnit versions? That method was static in PHPUnit 10.5 and was changed to non-static in recent version (11.5 for reference). |
Contributor
Author
|
This was annoying me when adding a new PHPUnit 11 test, one editor plugin was suggestion to use Anyway, somebody else is working on a fix: PHP-CS-Fixer/PHP-CS-Fixer#8205 |
Contributor
🎉 So there's 2 options now, we either a) just wait for the fix, or b) merge this one with the note to re-enable the rule once the fix is incorporated. I would be fine with both, granted the secondary action in b would actually happen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For instance
$this->once()was changed toself::once()