Open
Conversation
Necessary for testing the validity of the output from Hessenberg decomposition.
We don't need the buffer to be a specific size, it's sufficient that it's large enough to hold the intermediate data. This simplifies usage a little, since we don't need to truncate or resize the buffer when it is reused for different instances of HouseholderReflection.
The composition of Householder matrices for QR decomposition and Upper Hessenberg decomposition is very similar. We can exploit this to reuse virtually all code we have written for HouseholderComposition in the QR decomposition to implement the Hessenberg decomposition. We do this by adding a "subdiagonal" parameter to HouseholderComposition which controls the subdiagonal to pull Householder reflectors from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AtheMathmo#179