fix: fix app version + setting button#13
Merged
momenbasel merged 1 commit intomomenbasel:mainfrom Apr 14, 2026
Merged
Conversation
momenbasel
approved these changes
Apr 14, 2026
Owner
momenbasel
left a comment
momenbasel
left a comment
There was a problem hiding this comment.
LGTM. Dynamic version from Bundle + SettingsLink for macOS 14+ with correct fallback. Clean implementation.
5 tasks
Owner
|
Great fixes @theosementa! The SettingsLink approach for macOS 14+ is the right way to handle it, and pulling the version from Bundle is much better than hardcoding. Thanks for tackling both issues in one clean PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
close #10
Type of change
Testing
Screenshots