Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

@gribnoysup gribnoysup commented Dec 8, 2025

This patch adds continuous publishing for compass-web assets to a publicly available resource. We're temporarily using the same bucket used for compass desktop installers (downloads.mongodb.com/compass), but will eventually move to its own dedicated one

@gribnoysup gribnoysup added the wip label Dec 8, 2025
@github-actions github-actions bot added the feat label Dec 8, 2025
@gribnoysup gribnoysup force-pushed the upload-compass-web-to-s3 branch 4 times, most recently from bc7a9e9 to d7f51ce Compare December 8, 2025 12:59
@gribnoysup gribnoysup force-pushed the upload-compass-web-to-s3 branch from d7f51ce to 3e30d7d Compare December 8, 2025 14:39
@gribnoysup gribnoysup added no release notes Fix or feature not for release notes and removed wip labels Dec 8, 2025
test: /\.(jpe?g|png|svg|gif)(\?.+?)?$/,
// it's convenient to inline images as data-urls to make sure that publised
// library artifacts only produce importable javascript assets
type: 'asset/inline',
Copy link
Collaborator Author

@gribnoysup gribnoysup Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just easier not to deal with them for compass-web which is published as a library, they are all relatively small (the biggest is like 5kb) so data-urls work well enough

Copy link
Collaborator Author

@gribnoysup gribnoysup Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is maybe an argument for this code to be a part of hadron-build upload script, but I didn't want to add to the code we already know we need to heavily refactor in the future. Keeping it closer to compass-web seems reasonable to me for now, we can move this all to one place later down the road

- name: test-packaged-app-macos-15-x64
display_name: Test Packaged App MacOS x64 15
run_on: macos-15-amd64-gui
patchable: true
Copy link
Collaborator Author

@gribnoysup gribnoysup Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by fix: at some point we updated the template (the .in file), but not the actual config

GITHUB_TOKEN: ${devtoolsbot_github_token}
DOWNLOAD_CENTER_AWS_ACCESS_KEY_ID: ${aws_key_evergreen_integrations}
DOWNLOAD_CENTER_AWS_SECRET_ACCESS_KEY: ${aws_secret_evergreen_integrations}
DOWNLOAD_CENTER_NEW_AWS_ACCESS_KEY_ID: ${AWS_ACCESS_KEY_ID}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit of an overkill moving it here taking into account we will be using a different bucket, but this anyway seems more consistent with how we do it for other variables

Copy link
Contributor

@lerouxb lerouxb Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. I have no real opinion.

@gribnoysup gribnoysup marked this pull request as ready for review December 8, 2025 15:22
@gribnoysup gribnoysup requested a review from a team as a code owner December 8, 2025 15:22
@gribnoysup gribnoysup requested a review from tculig December 8, 2025 15:22
@gribnoysup gribnoysup changed the title feat(web, ci): upload compass-web assets to an s3 bucket during publish feat(web, ci): upload compass-web assets to an s3 bucket during publish COMPASS-10132 Dec 8, 2025
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Dec 8, 2025
@gribnoysup
Copy link
Collaborator Author

Latest commit was built and uploaded just fine: https://downloads.mongodb.com/compass/web/263691e49fdaf45dc4c396b57ad48e3b3d467e80/compass-web.mjs

Tested with redwood against deployed cloud environment and it loads okay without any extra changes required:

image

@gribnoysup gribnoysup force-pushed the upload-compass-web-to-s3 branch from cd8b863 to 70bddfd Compare December 9, 2025 09:08
Copy link
Collaborator

@ivandevp ivandevp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gribnoysup gribnoysup merged commit 26d8a2f into main Dec 9, 2025
83 of 84 checks passed
@gribnoysup gribnoysup deleted the upload-compass-web-to-s3 branch December 9, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants