PYTHON-4499 Log pymongo.connection at DEBUG without EventListeners #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We discussed adding a test to ensure the log is working without listeners. |
Contributor
Author
Test added that covers all three existing |
ShaneHarvey
requested changes
Jun 25, 2024
pymongo/asynchronous/pool.py
Outdated
| and self.opts._event_listeners is not None | ||
| and self.opts._event_listeners.enabled_for_cmap | ||
| ) | ||
| self.enabled_for_logging = self.handshake and not self.opts.is_monitor |
Member
There was a problem hiding this comment.
is_monitor is a duplicate of handshake. handshake is false for monitor pools and True for app pools. I suggest removing it.
ShaneHarvey
approved these changes
Jun 25, 2024
NoahStapp
added a commit
to NoahStapp/mongo-python-driver
that referenced
this pull request
Jun 25, 2024
NoahStapp
added a commit
to NoahStapp/mongo-python-driver
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.