PYTHON-3260 Improve test_transaction_starts_with_batched_write and test_continuous_network_errors #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Jun 29, 2022
…st_continuous_network_errors (mongodb#945)
blink1073
pushed a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Oct 31, 2022
…st_continuous_network_errors (mongodb#945) (cherry picked from commit a624197)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PYTHON-3260
For test_continuous_network_errors, I raised the server selection timeout a bit and also raised the delta from 10 to 15.
For test_transaction_starts_with_batched_write, I reduced the amount of data written from ~100 MB to ~48MB and also utilized RawBSONDocuments to speed up the bulk_write call. These changes reduce the amount of work required in the transaction and so should lead to TransactionExceededLifetimeLimitSeconds errors.