Merged
Conversation
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
Author
|
This is still applicable |
Member
|
LGTM. Please @yahiakr if you can review and approve. |
yahia-kerim
approved these changes
Aug 25, 2022
Collaborator
yahia-kerim
left a comment
yahia-kerim
left a comment
There was a problem hiding this comment.
Hey @callumgare, Thank you for your contribution.
LGTM!
callumgare
added a commit
to callumgare/mongoosastic
that referenced
this pull request
Sep 19, 2022
callumgare
added a commit
to callumgare/mongoosastic
that referenced
this pull request
Sep 19, 2022
guumaster
pushed a commit
that referenced
this pull request
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell the "customProperties" option is broken. The docs mention a option called
customPropertiescan be passed in but looking at the actual code such an option is never used. Apropertiesoption is however used so I can only assume this what the docs mean to say instead ofcustomProperties.There is a test for
customPropertiesbut it doesn't work for a number of reasons including the fact that it doesn't callcreateMapping()which the docs state (and I can confirm) is needed for these properties to be used.I have updated the documentation and fixed + extended the tests.