Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Mar 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean, well-structured foundational change that follows the existing PMIntegrationRegistry pattern faithfully. The IntegrationModule interface correctly generalizes the common contract from PMIntegration, the registry implementation is sound (with the nice improvement of throwing on duplicate registration rather than silently overwriting), tests are thorough, and CI is fully green. Purely additive with no risk to existing code.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntegrationModuleinterface insrc/integrations/types.ts— the category-agnostic contract every integration (PM, SCM, Alerting) must implementIntegrationRegistryclass insrc/integrations/registry.tswithregister(),get(),getOrNull(),getByCategory(),all(), andhasIntegration()methodsintegrationRegistryfromsrc/integrations/index.tsvitest.config.tsto includetests/unit/integrations/**in theunit-coretest projectDetails
The
IntegrationModuleinterface defines four required members:type: string— unique provider identifiercategory: IntegrationCategory— imported from existingsrc/config/integrationRoles.tswithCredentials<T>()— run a callback within the credential scope for a projecthasIntegration()— check if a project has this integration fully configuredPlus optional webhook methods:
parseWebhookPayload(),isSelfAuthored(),lookupProject(),extractWorkItemId().The
IntegrationRegistryfollows the same pattern as the existingPMIntegrationRegistryinsrc/pm/registry.ts, addinggetByCategory()andhasIntegration(type, projectId)for cross-cutting queries.This is a purely additive change — no existing files are modified except
vitest.config.ts(to include new test directory).Test plan
tests/unit/integrations/registry.test.tspassunit-coretest suite passes (214 files, 3995 tests)Closes https://trello.com/c/hs3cC1F9/543-as-a-developer-i-want-unified-integrationmodule-interfaces-and-integrationregistry-so-that-all-integration-types-share-a-common
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details