Conversation
… providers in unified registry
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Mar 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM — Clean integration of PM providers into the unified IntegrationModule registry. The interface extension is well-designed, hasIntegration() implementations correctly delegate to the same PROVIDER_CREDENTIAL_ROLES data source as the existing hasPmIntegration(), all integrationRegistry.register() calls are properly guarded against the registry's duplicate-throw behavior, and test coverage is thorough.
Notes
- The
category: 'pm'onGitHubWebhookIntegrationis a type system constraint from implementingPMIntegration(which narrowsIntegrationModule.category). The comment correctly explains it's not a real PM provider and won't be registered in the integration registry. src/pm/index.tsstill has unguardedpmRegistry.register()calls (unlikebootstrap.tswhich guards both). This is a pre-existing pattern —pmRegistryusesMap.set()(silent overwrite) so it won't throw, but when both files are imported in the same process (router importsbootstrap.js, then triggers importpm/index.js), thepmRegistryandintegrationRegistrywill hold different object instances for the same provider. Since the integration classes are stateless, this has no behavioral impact, but it's worth noting for future awareness.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IntegrationModuleinterface so they participate in theintegrationRegistryPMIntegrationnow extendsIntegrationModulewithcategory: 'pm'andhasIntegration()requiredTrelloIntegrationandJiraIntegrationimplementhasIntegration()by delegating toPROVIDER_CREDENTIAL_ROLES(same logic as standalonehasPmIntegration())src/pm/bootstrap.tsandsrc/pm/index.tsregister Trello/JIRA into bothpmRegistryandintegrationRegistryhasPmIntegration()function is kept unchanged for backward compatibilityGitHubWebhookIntegrationupdated to satisfy new interface requirements (addscategory: 'pm'and a no-ophasIntegration()since it is a PM-pipeline adapter, not a real PM provider)Trello card: https://trello.com/c/q6ESNAaG/544-as-a-developer-i-want-pmintegration-to-extend-integrationmodule-so-that-pm-providers-participate-in-the-unified-registry
Test plan
TrelloIntegration.hasIntegration()returns true when provider is trello with required credentialsTrelloIntegration.hasIntegration()returns false when provider is not trello or credentials are missingJiraIntegration.hasIntegration()returns true when provider is jira with required credentialsJiraIntegration.hasIntegration()returns false when provider is not jira or credentials are missingcategory: 'pm'🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details