feat(integrations): add SCMIntegration interface and GitHubSCMIntegration class#1027
Merged
feat(integrations): add SCMIntegration interface and GitHubSCMIntegration class#1027
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Mar 24, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean, well-structured foundation work for the SCM integration abstraction.
The SCMIntegration interface correctly extends IntegrationModule with the narrowed category: 'scm' and SCM-specific hasPersonaToken(). The GitHubSCMIntegration implementation faithfully mirrors the existing standalone functions in src/github/integration.ts and follows the same patterns established by TrelloIntegration and JiraIntegration (guard-based registration, withCredentials delegation, hasIntegration credential checking).
Key points verified:
- No
typecollision withGitHubWebhookIntegration— that class is never registered inintegrationRegistry(only used locally in the webhook handler), so the newtype = 'github'registration is safe withCredentialshardcoding toimplementer_tokenis intentional and consistent with howGitHubWebhookIntegration.withCredentials()uses the implementation personabootstrap.tsdoc comment and module header were properly updated to reflect the expanded scope (PM + SCM)- Backward compatibility preserved — standalone functions in
src/github/integration.tsremain untouched - 18 tests comprehensively cover all methods, edge cases, and error propagation paths
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCMIntegrationinterface insrc/integrations/scm.ts— extendsIntegrationModulewithcategory: 'scm'and ahasPersonaToken()methodGitHubSCMIntegrationclass insrc/github/scm-integration.ts— implementsSCMIntegrationwithwithCredentials(),hasIntegration(), andhasPersonaToken()GitHubSCMIntegrationinintegrationRegistryvia the bootstrap module (src/pm/bootstrap.ts)hasScmIntegration()andhasScmPersonaToken()functions insrc/github/integration.tsremain unchanged and continue to work identicallyGitHubSCMIntegrationCloses: https://trello.com/c/69c1af91066cefb9a97bbaa1
Test plan
GitHubSCMIntegrationpass🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details