feat(integrations): add unified integration bootstrap#1041
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Mar 24, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
Clean, well-structured change that consolidates integration bootstrap into a single canonical module. The implementation is correct, idempotent, tests are thorough, and CI is fully green. Ready to merge.
Code Issues
Should Fix
- src/integrations/bootstrap.ts:28 — The import
'../integrations/registry.js'resolves correctly but is a redundant traversal since the file is already insidesrc/integrations/. Should be'./registry.js'for clarity and consistency with how other local imports work.
Observations (non-blocking)
src/pm/bootstrap.tsis no longer imported by any production source file (only referenced as a stale mock intests/unit/router/webhook-signature.test.ts:77). Consider removing it in a follow-up to avoid confusion about which bootstrap is canonical, or update the stale mock to reference the new path.src/pm/index.tsstill performs its own registration of Trello/Jira integrations at import time (without idempotency guards onpmRegistry). Whenpm/index.tsis eventually imported at runtime (via trigger handlers, gadgets, etc.), it creates new instances that overwrite the ones placed inpmRegistryby the bootstrap. TheintegrationRegistryguards prevent double registration there, sointegrationRegistryandpmRegistryend up holding different object instances for the same providers. This is pre-existing and not introduced by this PR, but worth noting for future cleanup.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/integrations/bootstrap.tsas the canonical registration point for all 4 integrations (Trello, JIRA, GitHub, Sentry) intointegrationRegistrysrc/router/index.tsto import the unified bootstrap instead of../pm/bootstrap.jssrc/worker-entry.tsto import the unified bootstrap (previously had no integration bootstrap)getOrNull()guards before callingregister()src/pm/bootstrap.tsis unchanged and continues to work for backward compatibilityCloses card: https://trello.com/c/29Oiq2iN/547-as-a-developer-i-want-unified-integration-bootstrap-so-that-all-providers-register-in-one-place
Test plan
tests/unit/integrations/bootstrap.test.tsverifies all 4 integrations are registered after importing bootstrapintegrationRegistryandpmRegistry(backward compat)🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details