chore(deps): upgrade @biomejs/biome from 1.9.4 to 2.4.10#1075
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Apr 2, 2026
Collaborator
nhopeatall
left a comment
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM — clean Biome v1 → v2 major version upgrade with correct config migration and comprehensive auto-fix application.
What I verified:
-
Config migration is correct:
organizeImports.enabled→assist.actions.source.organizeImports,files.ignore→files.includeswith negation patterns — both match Biome v2's documented schema changes. -
Behavioral code changes are sound:
Number.parseInt(t.id, 10)— adds explicit radix toparseInt, functionally equivalent since IDs are always decimal strings generated by the same function!result?.trim()simplifications (3 occurrences) — semantically equivalent to!result || !result.trim()_output/_config/_projectunderscore-prefix renames for unused variables — correct convention, variables are unused but their assignment has necessary side effects (e.g., consuming stdout pipe buffer in AstGrep)- Removed dead
removeIntegrationCredentialimport in test seed helper — function body was already a no-op stub
-
Bulk changes are mechanical: ~90 files with import reordering (alphabetical per Biome v2's
organizeImports), export reordering, and minor formatting (blank line insertions, multi-line → single-line consolidation). All are safe reorganizations with no semantic impact. -
Exclusion of
web/src/index.cssfrom Biome checks is reasonable — Tailwind v4 uses custom CSS syntax that Biome's CSS parser doesn't support. -
CI is green: All 7 checks pass (lint, typecheck, tests, Docker builds, integration tests).
🕵️ claude-code · claude-opus-4-6 · run details
zbigniewsobiecki
added a commit
that referenced
this pull request
Apr 15, 2026
Local node_modules had biome 1.9.4 (stale from before #1075), so the previous commit wrote a 1.9.4 config that broke CI (which installs fresh 2.4.10). After running npm install locally, re-wrote config for 2.4.10: - Restore assist/files.includes keys (valid 2.x API) - Keep noDelete: off override (src/ + tests/) — delete process.env.X is semantically required; = undefined coerces to "undefined" string - Add noArrayIndexKey suppression back to llm-call-list (2.4.10 triggers the rule even for compound keys; suppression is warranted — read-only list) - Re-apply biome 2.4.10 import sort across modified files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
zbigniewsobiecki
added a commit
that referenced
this pull request
Apr 15, 2026
#1112) * fix(linear): remove Bearer prefix from API key auth header + fix biome config **Bug fix:** Linear personal API keys (lin_api_*) must be sent as bare Authorization tokens — not Bearer tokens. Bearer is for OAuth access tokens only. Every outbound Linear API call (getMe, getTeams, createIssue, etc.) was broken for any project using a personal key. Reproducer: curl -H "Authorization: Bearer lin_api_..." returned "Remove the Bearer prefix from the Authorization header." **Also included:** - Add logger.error in wrapIntegrationCall so integration failures are visible in server logs (previously swallowed silently) - Add getMe unit tests (the method that was failing in the wizard) - Fix biome.json: schema ref was 2.4.10 but installed biome is 1.9.4; also renamed assist→organizeImports, includes→ignore (1.9.x keys) - Run biome check --write to apply all import-sort and style fixes across the entire codebase (pre-existing issues, now unblocked) - Add biome override to keep noDelete off for src/ and tests/ — delete process.env.X is semantically required (= undefined coerces to the string "undefined" in Node.js process.env) - Remove stale biome-ignore comment in llm-call-list.tsx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(lint): align biome.json with installed version 2.4.10 Local node_modules had biome 1.9.4 (stale from before #1075), so the previous commit wrote a 1.9.4 config that broke CI (which installs fresh 2.4.10). After running npm install locally, re-wrote config for 2.4.10: - Restore assist/files.includes keys (valid 2.x API) - Keep noDelete: off override (src/ + tests/) — delete process.env.X is semantically required; = undefined coerces to "undefined" string - Add noArrayIndexKey suppression back to llm-call-list (2.4.10 triggers the rule even for compound keys; suppression is warranted — read-only list) - Re-apply biome 2.4.10 import sort across modified files Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@biomejs/biomefrom 1.9.4 → 2.4.10 (major version bump)biome.jsonconfig schema viabiome migrate --write(organizeImports→assist.actions.source.organizeImports,files.ignore→files.includes)biome-ignore lint/performance/noDeletesuppressionsnoArrayIndexKey,useExhaustiveDependencies,noTemplateCurlyInString,noUnusedFunctionParameters,noUnusedVariablesweb/src/index.cssfrom Biome checks (Tailwind v4 syntax unsupported by Biome CSS parser)noExcessiveCognitiveComplexitywarnings inusers.tsandwebhooks.tsremain (expected)Closes: https://trello.com/c/iQZ0yjGB/585-biome-linter-major-version-behind-biomejs-biome-at-194-latest-is-2410-major-version-gap-may-miss-new-lint-rules-and-improvements
Test plan
npm run lint— 0 errors, 2 pre-existing warningsnpm run typecheck— 0 errorsnpm test— 369 test files, 7262 tests all passingnpm run build— compilation succeedsnpx biome check --write {staged_files}CLI interface unchanged🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details