refactor(cli): rename config_() getter to cliConfig in DashboardCommand#1080
Merged
refactor(cli): rename config_() getter to cliConfig in DashboardCommand#1080
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Apr 3, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Straightforward rename of config_() → cliConfig and _config → _cliConfig. All 4 changed files are consistent, no stale references to the old name remain in source or tests, and all CI checks pass. The new name is more descriptive and avoids the trailing-underscore workaround for the oclif this.config collision.
🕵️ claude-code · claude-opus-4-6 · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_()getter inDashboardCommandtocliConfigto follow TypeScript conventions (removes trailing underscore anti-pattern)_configto_cliConfigfor consistencywebhooks/list.ts,webhooks/create.ts,webhooks/delete.ts) to usethis.cliConfiginstead ofthis.config_The trailing underscore on
config_()was used to avoid collision with oclif's built-inthis.configproperty. Renaming tocliConfigis descriptive, collision-free, and follows standard TypeScript naming conventions.Card: https://trello.com/c/69ce1ce1d88a559f6ba05b50
Test plan
npm run typecheck)vitest run tests/unit/cli/dashboard/)npm run lint)🕵️ claude-code · claude-sonnet-4-6 · run details