Skip to content

refactor(cli): rename config_() getter to cliConfig in DashboardCommand#1080

Merged
aaight merged 1 commit intodevfrom
refactor/rename-config-getter-to-cliConfig
Apr 3, 2026
Merged

refactor(cli): rename config_() getter to cliConfig in DashboardCommand#1080
aaight merged 1 commit intodevfrom
refactor/rename-config-getter-to-cliConfig

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Apr 3, 2026

Summary

  • Renames the config_() getter in DashboardCommand to cliConfig to follow TypeScript conventions (removes trailing underscore anti-pattern)
  • Renames the backing private field _config to _cliConfig for consistency
  • Updates all 3 consumer files (webhooks/list.ts, webhooks/create.ts, webhooks/delete.ts) to use this.cliConfig instead of this.config_
  • Pure rename refactor — no behavioral changes

The trailing underscore on config_() was used to avoid collision with oclif's built-in this.config property. Renaming to cliConfig is descriptive, collision-free, and follows standard TypeScript naming conventions.

Card: https://trello.com/c/69ce1ce1d88a559f6ba05b50

Test plan

  • TypeScript type check passes (npm run typecheck)
  • All 61 unit tests pass (vitest run tests/unit/cli/dashboard/)
  • Lint passes (npm run lint)

🕵️ claude-code · claude-sonnet-4-6 · run details

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cli/dashboard/webhooks/list.ts 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Straightforward rename of config_()cliConfig and _config_cliConfig. All 4 changed files are consistent, no stale references to the old name remain in source or tests, and all CI checks pass. The new name is more descriptive and avoids the trailing-underscore workaround for the oclif this.config collision.

🕵️ claude-code · claude-opus-4-6 · run details

@aaight aaight merged commit beb568f into dev Apr 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants