fix: web build + dev deploy failing on tsc strict checks

[zbigniewsobiecki]

Summary

The dev deploy + CI Build frontend step have been failing since PR #1148 (spec 011 merge). Root cause: cd web && npm run build runs tsc -b which is stricter than the root npm run typecheck that my local verification uses. Three classes of errors surfaced on the deploy logs:

1. readonly /** jsdoc */ fieldName pattern (TS7008)

steps/webhook-url-display.tsx + steps/container-pick.tsx had the JSDoc comment between readonly and the field name. Stricter tsc parses this as readonly: any + bare fieldName: string without the readonly modifier. Pre-existing from spec 010/3. Downstream callers couldn't satisfy the broken interface (TS2345 cascade). Fixed by moving JSDoc above readonly.

2. currentUser Zod-enum / type-union drift

pm-wizard-hooks.ts verify-button calls pm.discovery.discover({capability: 'currentUser', …}). The backend type union (DiscoveryCapability in src/pm/types.ts) included 'currentUser' from spec 010/2 but the Zod enum at the tRPC input schema was never updated — so every wizard Verify-button call fails at runtime Zod validation. Fixed by promoting the enum to src/pm/types.ts as DISCOVERY_CAPABILITIES (const array) and deriving both the type union AND the tRPC Zod enum from it. The two can no longer drift structurally.

3. JIRA custom-field shape mismatch

jira/wizard.ts mapped jiraProjectDetails.fields (shape {id, name, custom}) directly to providerCustomFields (shape {id, name, type}). Introduced by me in plan 011/3. Fixed by mapping custom: boolean → type: 'custom' | 'standard'.

Why wasn't this caught locally

• npm run typecheck (root) uses the root tsconfig.json — looser.
• cd web && npm run build uses web/tsconfig.json — stricter, runs tsc -b.
• The deploy + CI Build frontend steps run the web tsc. My local verification didn't.

Going forward I'll add cd web && npm run build to my verification checklist, and/or we could make the root pre-commit/pre-push hook also run it.

Test plan

• New regression test in tests/unit/api/pm-discovery.test.ts: accepts currentUser capability (closes Zod-enum / type-union drift) — pins the root-cause invariant.
• 13 existing pm-discovery tests continue to pass.
• Full suite: 8187/8187 (+1 new test, no regressions).
• npm run lint — clean.
• npm run typecheck (root) — green.
• npm run build (root) — green.
• cd web && npm run build (the production step that was failing) — green for the first time since feat(pm): integration hardening follow-ups + wizard shared-component migration (specs 010 + 011/1-2) #1148.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!