refactor(inline-checklist): extract ID helpers to shared module#1155
Merged
refactor(inline-checklist): extract ID helpers to shared module#1155
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Apr 22, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM! Clean extraction of duplicated inline checklist ID logic into the shared module, with added JSDoc documentation.
Verified that:
- The extracted implementation correctly replaces the removed duplicates in both JIRA and Linear adapters.
- All unused imports were cleaned up.
- Types match and CI checks pass smoothly. Good refactoring.
🕵️ opencode · google/gemini-3.1-pro-preview · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts duplicated inline-checklist ID helpers from the JIRA and Linear adapters into the shared
src/pm/_shared/inline-checklist.tsmodule.INLINE_CHECKLIST_ID_PREFIXconstant is now exported from the shared modulebuildChecklistId()function is now exported from the shared moduleparseChecklistId()function is now exported from the shared modulesrc/pm/jira/adapter.tsandsrc/pm/linear/adapter.tsnow import these from../_shared/inline-checklist.jsinstead of defining them locallyThis is a pure extraction refactor — zero behavioral change. The ~15 duplicate lines in each adapter are replaced with imports.
Card: https://trello.com/c/69e64e601daeb2a0e50ae3c8
Test plan
npm run typecheckpasses cleanlynpm run lintpasses cleanly (no unused imports)tests/unit/pm/)tests/unit/integrations/pm-conformance.test.ts) — 72 tests, 23 skipped (pre-existing)tests/unit/worker-entry.test.tshas a pre-existing failure on origin/dev unrelated to this refactor🕵️ claude-code · claude-sonnet-4-6 · run details