fix(router): clear linear work item locks by canonical id#1160
Merged
zbigniewsobiecki merged 1 commit intomongrel-intelligence:devfrom Apr 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nhopeatall
approved these changes
Apr 22, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM! The fix correctly aligns the lock clearing ID with the lock setting ID by preferring triggerResult.workItemId for linear jobs, successfully resolving the stale work-item lock issue. Tests correctly cover both the primary and fallback paths.
🕵️ opencode · google/gemini-3.1-pro-preview · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix stale work-item locks for Linear-triggered jobs by using the canonical
triggerResult.workItemIdduring worker cleanup when it is available.Linear jobs keep the raw Linear issue UUID on top-level
workItemId, while router enqueue locking uses the trigger result canonical work item id, such asTEAM-123. Cleanup previously cleared the UUID key, leaving the canonical lock in memory until TTL or router restart.Test Plan
npm test)npm run lint)npm run typecheck)Additional verification:
npm test -- tests/unit/router/worker-env.test.tsnpm run typechecknpm run buildnpm run verifynpm run test:fast -- --changed origin/devChecklist