Conversation
nhopeatall
approved these changes
Apr 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM! The fix perfectly addresses the UI bug by correctly gating the checkmarks of optional steps on the completion of the required setup stages. The implementation is clean, the type-safety is well maintained, and the newly added unit tests thoroughly cover all states (fresh, partial, complete, and edit mode).
No issues found.
🕵️ opencode · google/gemini-3.1-pro-preview · run details
nhopeatall
approved these changes
Apr 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
LGTM! The fix successfully resolves the UI bug by correctly gating the completion of optional wizard steps behind the required configurations, and the test coverage is thorough.
Nitpicks
- The new
are[Provider]RequiredStepsDonehelpers replicate the exact same logic currently found in each provider'sisSetupCompletepredicate (e.g.isSetupComplete: (state) => { if (!state.jiraProjectKey) return false; ... return isCredentialsComplete(state); }). You could replace the body ofisSetupCompletewithreturn are[Provider]RequiredStepsDone(state)to DRY this up.
🕵️ opencode · google/gemini-3.1-pro-preview · run details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isComplete: () => true, which caused green checkmarks to appear on brand-new unconfigured integrationsareTrelloRequiredStepsDone,areJiraRequiredStepsDone,areLinearRequiredStepsDonehelper functions that gate on credentials + container + status mapping all being complete; optional steps delegate to these helpersisSetupCompletealready gates correctly)Changes
Provider wizard definitions (3 files)
web/src/components/projects/pm-providers/trello/wizard.ts— AddedareTrelloRequiredStepsDone()helper; changedtrello-labels,trello-custom-fields,trello-webhookfrom() => trueto gated predicateweb/src/components/projects/pm-providers/jira/wizard.ts— AddedareJiraRequiredStepsDone()helper; changedjira-labels,jira-custom-fields,jira-issue-types,jira-webhookfrom() => trueto gated predicateweb/src/components/projects/pm-providers/linear/wizard.ts— AddedareLinearRequiredStepsDone()helper; changedlinear-labels,linear-project-scope,linear-webhookfrom() => trueto gated predicateUnit tests (3 new files)
tests/unit/web/trello-wizard-isComplete.test.ts— 14 tests covering fresh state, partial config, full config, and edit modetests/unit/web/jira-wizard-isComplete.test.ts— 18 tests covering fresh state, partial config, full config, and edit modetests/unit/web/linear-wizard-isComplete.test.ts— 15 tests covering fresh state, partial config, full config, and edit modeTest plan
Card
https://trello.com/c/69ea6fa377589654451ee944
🤖 Generated with Claude Code
🕵️ claude-code · claude-sonnet-4-6 · run details