feat(agents): add separate reviewer GitHub identity (PAT)#154
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 12, 2026
Merged
feat(agents): add separate reviewer GitHub identity (PAT)#154zbigniewsobiecki merged 1 commit intodevfrom
zbigniewsobiecki merged 1 commit intodevfrom
Conversation
…orage scoping GitHub doesn't allow the same user to review their own PR. CASCADE uses a single GITHUB_TOKEN for everything — creating PRs (implementation agent) and reviewing them (review agent). This adds a separate reviewer PAT per project so the review agent operates as a different GitHub user. Uses Node.js AsyncLocalStorage to transparently scope a different Octokit instance to the review agent's async context. The existing getClient() function is the single chokepoint — modifying it to check AsyncLocalStorage first means zero changes to any gadget files and zero changes to the githubClient API surface. Changes: - Add optional `reviewerTokenEnv` field to project config schema - Add AsyncLocalStorage-based `withGitHubToken()` for scoped GitHub clients - Add `getReviewerUser()` with caching for resolving reviewer identity - Wrap review agent lifecycle in reviewer scope when configured - Extend `isSelfAuthored()` and check-suite-success trigger to recognize reviewer identity (prevents infinite loops and duplicate reviews) - Review agent now posts initial "reviewing" comment and includes UpdatePRComment gadget for updating it with review summary - Enable reviewer token for niu and car-dealership projects Graceful fallback: no reviewerTokenEnv → existing behavior unchanged; env var not set → logs warning, uses main token; API failure → returns null, triggers don't filter (safe default). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
zbigniewsobiecki
added a commit
that referenced
this pull request
Feb 12, 2026
The review agent's separate reviewer identity (added in #154) requires GITHUB_REVIEWER_TOKEN in the worker environment. Without it, the agent falls back to the main GITHUB_TOKEN, authenticates as the PR author, and GitHub rejects REQUEST_CHANGES with 422 ("can not request changes on your own pull request"). Add the token to router secrets, worker container env, and local Docker runs so the reviewer identity works end-to-end. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
zbigniewsobiecki
added a commit
that referenced
this pull request
Feb 12, 2026
The review agent's separate reviewer identity (added in #154) requires GITHUB_REVIEWER_TOKEN in the worker environment. Without it, the agent falls back to the main GITHUB_TOKEN, authenticates as the PR author, and GitHub rejects REQUEST_CHANGES with 422 ("can not request changes on your own pull request"). Add the token to router secrets, worker container env, and local Docker runs so the reviewer identity works end-to-end. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsyncLocalStorageto transparently scope a different Octokit instance to the review agent's async context, letting the review agent submit real PR reviews under a different GitHub user than the one that created the PRgetClient()checksAsyncLocalStoragefirst, so all 9 gadget files and the entiregithubClientAPI surface remain untouchedUpdatePRCommentgadget so the agent can update it with the review summaryHow it works
Changes
schema.ts,projects.jsonreviewerTokenEnvfield; enable for niu + car-dealershipclient.tsAsyncLocalStorage,withGitHubToken(),getReviewerUser(), scopedgetClient()review.ts,review.etautils.ts, 4 trigger handlersisSelfAuthored()+ "already reviewed" check for reviewer identity.env.exampleGITHUB_REVIEWER_TOKENenv varGraceful fallback
reviewerTokenEnvconfigured → everything works exactly as beforegetReviewerUser()API call fails → logs warning, returns null, triggers don't filter (safe default)Test plan
npm run typecheck— no type errorsnpm run lint— no new lint errorsnpm test— all 459 tests pass (including 8 new ones)🤖 Generated with Claude Code