Skip to content

fix: redis startup fails due to nologin shell #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbigniewsobiecki merged 7 commits into from
Jan 2, 2026
Merged

fix: redis startup fails due to nologin shell #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1124fcb
feat: add Redis configuration and startup for agents (#13)
zbigniewsobiecki Jan 2, 2026
b2d274e
fix: increase post-job grace period to allow debug agent webhooks
zbigniewsobiecki Jan 2, 2026
b1809e2
feat: add support for GitHub PR review submission webhooks
zbigniewsobiecki Jan 2, 2026
61c84eb
fix: move cards to IN REVIEW after PR creation from GitHub webhooks
zbigniewsobiecki Jan 2, 2026
0fede46
docs: add GitHub webhook integration documentation
zbigniewsobiecki Jan 2, 2026
d300ed3
fix: redis startup fails due to nologin shell (#15)
zbigniewsobiecki Jan 2, 2026
588187f
Merge branch 'main' into dev - resolve conflicts for Redis fix
zbigniewsobiecki Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/agents/prompts/templates/partials/environment.eta
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
- `redis-cli KEYS "*"` - List all keys (use sparingly)
- `redis-cli FLUSHALL` - Clear all data (use with caution)
- `redis-cli INFO` - Get server statistics
- **Start**: `su redis -c 'redis-server /etc/redis/redis.conf --daemonize yes'`
- **Start**: `su -s /bin/sh redis -c 'redis-server /etc/redis/redis.conf --daemonize yes'`
- **Stop**: `redis-cli SHUTDOWN`
- **Monitor**: `redis-cli MONITOR` - Watch all commands in real-time
- **Data persistence**: AOF enabled (data survives restarts)
Expand Down
4 changes: 2 additions & 2 deletions src/agents/utils/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ export async function startRedis(): Promise<void> {

try {
// Start Redis in background using redis-server
// We use su to run as redis user, and redirect stderr to capture startup errors
// We use su -s /bin/sh to run as redis user (redis user has /usr/sbin/nologin shell by default)
const startResult = await execCommand(
'su',
['redis', '-c', `redis-server ${REDIS_CONF} --daemonize yes 2>&1`],
['-s', '/bin/sh', 'redis', '-c', `redis-server ${REDIS_CONF} --daemonize yes 2>&1`],
'/',
);
logger.debug('redis-server start output', {
Expand Down