Skip to content

fix: review agent uses wrong GitHub identity (agent credential override ignored)#308

Merged
zbigniewsobiecki merged 1 commit intodevfrom
fix/review-agent-credential-override
Feb 16, 2026
Merged

fix: review agent uses wrong GitHub identity (agent credential override ignored)#308
zbigniewsobiecki merged 1 commit intodevfrom
fix/review-agent-credential-override

Conversation

@zbigniewsobiecki
Copy link
Copy Markdown
Member

Summary

  • executeGitHubAgent() always resolved the default project GITHUB_TOKEN via getProjectSecret(), ignoring per-agent credential overrides configured in project_credential_overrides
  • This caused the review agent to authenticate as the repo owner (zbigniewsobiecki) instead of the dedicated review bot (aight), triggering GitHub 422 errors: "Can not approve your own pull request"
  • Now resolves agent-scoped credentials first via getAgentCredential(), falling back to the project default only when no override exists

Test plan

🤖 Generated with Claude Code

executeGitHubAgent() always used the default project GITHUB_TOKEN,
ignoring per-agent credential overrides. This caused the review agent
to authenticate as the repo owner instead of the dedicated review bot,
triggering GitHub 422 errors ("Can not approve your own pull request").

Resolve agent-scoped credentials first via getAgentCredential(), falling
back to the project default only when no override exists.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@zbigniewsobiecki zbigniewsobiecki merged commit 2de67b7 into dev Feb 16, 2026
4 checks passed
@zbigniewsobiecki zbigniewsobiecki deleted the fix/review-agent-credential-override branch February 16, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant