Skip to content

fix: check-suite-success trigger uses token without actions permission #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zbigniewsobiecki merged 1 commit into from
Feb 16, 2026
Merged

fix: check-suite-success trigger uses token without actions permission #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/triggers/github/check-suite-success.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import { getAgentCredential } from '../../config/provider.js';
import { getAuthenticatedUser, getGitHubUserForToken, githubClient } from '../../github/client.js';
import {
getAuthenticatedUser,
getGitHubUserForToken,
githubClient,
withGitHubToken,
} from '../../github/client.js';
import type { TriggerContext, TriggerHandler, TriggerResult } from '../../types/index.js';
import { logger } from '../../utils/logging.js';
import { type GitHubCheckSuitePayload, isGitHubCheckSuitePayload } from './types.js';
Expand Down Expand Up @@ -100,7 +105,12 @@ export class CheckSuiteSuccessTrigger implements TriggerHandler {
}

// Verify all checks are actually passing (double-check)
const checkStatus = await githubClient.getCheckSuiteStatus(owner, repo, headSha);
// Use the review agent's token if available, since the default project token
// may lack actions:read permission (fine-grained PATs need it explicitly).
const fetchCheckStatus = () => githubClient.getCheckSuiteStatus(owner, repo, headSha);
const checkStatus = agentGitHubToken
? await withGitHubToken(agentGitHubToken, fetchCheckStatus)
: await fetchCheckStatus();

if (!checkStatus.allPassing) {
logger.info('Not all checks passing, skipping review trigger', {
Expand Down