Skip to content

fix: pass preSeededCommentId in llmist backend + strengthen checklist prompt#474

Merged
zbigniewsobiecki merged 1 commit intodevfrom
fix/ack-comment-preseeded-id
Feb 22, 2026
Merged

fix: pass preSeededCommentId in llmist backend + strengthen checklist prompt#474
zbigniewsobiecki merged 1 commit intodevfrom
fix/ack-comment-preseeded-id

Conversation

@zbigniewsobiecki
Copy link
Copy Markdown
Member

Summary

  • Fix ack comment not replaced: The llmist backend path in executeAgent() was missing the preSeededCommentId parameter when creating ProgressMonitor, causing the router's ack comment to be orphaned while ProgressMonitor created a duplicate. Now passes input.ackCommentId through, matching the claude-code backend path.
  • Strengthen scope-narrowing prompt: Added explicit checklist management instructions to the respond-to-planning-comment prompt so agents use DeleteChecklistItem when narrowing scope instead of creating duplicate checklists or leaving stale items.
  • Carry ackCommentId through webhook queue: Extended QueuedWebhook and enqueueWebhook() with an ackCommentId field, and updated all three webhook handlers (JIRA, Trello, GitHub) plus the shared processNextQueuedWebhook helper to forward it. This prevents queued webhooks from losing their ack comment reference.

Test plan

  • Added 4 unit tests for ackCommentId preservation in webhookQueue.test.ts
  • Added 6 unit tests for processNextQueuedWebhook ackCommentId forwarding in webhook-queue.test.ts
  • npm run typecheck — clean
  • npm run lint — clean (only pre-existing cognitive complexity warnings)
  • npm test — all 2528 tests pass

🤖 Generated with Claude Code

… prompt

The llmist backend path in executeAgent() was missing the preSeededCommentId
parameter when creating ProgressMonitor, causing the ack comment posted by the
router to be orphaned while ProgressMonitor created a new comment. The
claude-code backend path already passed this correctly.

Also strengthens the respond-to-planning-comment prompt with explicit
instructions for checklist management (add/rename/delete) so agents use
DeleteChecklistItem when narrowing scope instead of creating duplicate
checklists.

Additionally carries ackCommentId through the in-worker webhook queue so
queued webhooks don't lose their ack comment reference.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@zbigniewsobiecki zbigniewsobiecki merged commit 7981e3d into dev Feb 22, 2026
5 checks passed
@zbigniewsobiecki zbigniewsobiecki deleted the fix/ack-comment-preseeded-id branch February 22, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant