fix(jira): fall back to transition when subtask delete returns 403#475
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 22, 2026
Merged
fix(jira): fall back to transition when subtask delete returns 403#475zbigniewsobiecki merged 1 commit intodevfrom
zbigniewsobiecki merged 1 commit intodevfrom
Conversation
When `deleteIssue()` fails with 403 (missing "Delete Issues" permission), fall back to transitioning the subtask to a terminal status (Cancelled, Won't Do, Rejected, Closed, or Done — in priority order). Also refactor webhook handlers in router/index.ts to extract helper functions, resolving all 3 pre-existing cognitive complexity warnings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deleteIssue()fails with 403 (missing "Delete Issues" permission), fall back to transitioning the subtask to a terminal status instead of silently failingsrc/router/index.tsto extract helper functions (isSelfAuthoredTrelloComment,processTrelloWebhookEvent,isSelfAuthoredGitHubComment,fireGitHubAckReaction,processGitHubWebhookEvent,isSelfAuthoredJiraComment), resolving all 3 pre-existing cognitive complexity lint warningsTest plan
deleteChecklistItemfallback behaviornpm run typecheck— cleannpm run lint— clean (0 warnings, down from 3)npm test— 2532 tests pass🤖 Generated with Claude Code