refactor(pm): clean up pm integration layer#476
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 22, 2026
Merged
Conversation
remove dead code, improve type safety, and eliminate duplication across the pm integration subsystem. changes: - remove unused getTriggerHandlers() from interface - remove unused withCredentials() from registry - change createProvider to accept ProjectConfig (removes unsafe PMProviderConfig casts) - change TriggerResult.agentType to string | null - delete factory.ts (inline into index.ts) - delegate ack/reaction methods in trello and jira integrations to existing router functions - consolidate resolveLifecycleConfig into registry - replace redundant createPMProvider calls with getPMProvider() in webhook-handler - migrate TriggerResult.cardId to workItemId Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-refactoring cleanup of the PM integration subsystem.
Removes dead code, improves type safety, eliminates
duplication, and consolidates lifecycle config into a
single source of truth.
getTriggerHandlers()from PMIntegrationinterface and both implementations
withCredentials()from registrycreateProvider()to acceptProjectConfigdirectly (eliminates unsafe
PMProviderConfigcasts)TriggerResult.agentTypefromstringtostring | null(explicit nullability)factory.ts(inline intoindex.ts)integrations to existing router functions (~200 lines
of duplicated code removed)
resolveLifecycleConfig— integrationimplementations become single source of truth
createPMProvider()calls withgetPMProvider()in webhook-handlerTriggerResult.cardIdtoworkItemIdacrossall 14 trigger files and 2 consumers
73 files changed, +1174 / -1809 lines
Test plan
imports where needed
🤖 Generated with Claude Code