Skip to content

refactor(pm): clean up pm integration layer#476

Merged
zbigniewsobiecki merged 1 commit intodevfrom
refactor/pm-integration-cleanup
Feb 22, 2026
Merged

refactor(pm): clean up pm integration layer#476
zbigniewsobiecki merged 1 commit intodevfrom
refactor/pm-integration-cleanup

Conversation

@zbigniewsobiecki
Copy link
Copy Markdown
Member

Summary

Post-refactoring cleanup of the PM integration subsystem.
Removes dead code, improves type safety, eliminates
duplication, and consolidates lifecycle config into a
single source of truth.

  • Remove unused getTriggerHandlers() from PMIntegration
    interface and both implementations
  • Remove unused withCredentials() from registry
  • Change createProvider() to accept ProjectConfig
    directly (eliminates unsafe PMProviderConfig casts)
  • Change TriggerResult.agentType from string to
    string | null (explicit nullability)
  • Delete factory.ts (inline into index.ts)
  • Delegate ack/reaction methods in Trello and JIRA
    integrations to existing router functions (~200 lines
    of duplicated code removed)
  • Consolidate resolveLifecycleConfig — integration
    implementations become single source of truth
  • Replace redundant createPMProvider() calls with
    getPMProvider() in webhook-handler
  • Migrate TriggerResult.cardId to workItemId across
    all 14 trigger files and 2 consumers

73 files changed, +1174 / -1809 lines

Test plan

  • All 155 test files pass (2489 tests)
  • TypeScript compiles with zero errors
  • ESLint passes with zero warnings
  • Pre-push hook passes (lint + typecheck + tests)
  • Updated test mocks for PM registry side-effect
    imports where needed

🤖 Generated with Claude Code

remove dead code, improve type safety, and eliminate
duplication across the pm integration subsystem.

changes:
- remove unused getTriggerHandlers() from interface
- remove unused withCredentials() from registry
- change createProvider to accept ProjectConfig
  (removes unsafe PMProviderConfig casts)
- change TriggerResult.agentType to string | null
- delete factory.ts (inline into index.ts)
- delegate ack/reaction methods in trello and jira
  integrations to existing router functions
- consolidate resolveLifecycleConfig into registry
- replace redundant createPMProvider calls with
  getPMProvider() in webhook-handler
- migrate TriggerResult.cardId to workItemId

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@zbigniewsobiecki zbigniewsobiecki merged commit 02d6928 into dev Feb 22, 2026
5 checks passed
@zbigniewsobiecki zbigniewsobiecki deleted the refactor/pm-integration-cleanup branch February 22, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant