feat(triggers): add per-agent JIRA issue-transitioned toggles and pm-trigger-set CLI#497
Merged
zbigniewsobiecki merged 2 commits intodevfrom Feb 23, 2026
Merged
Conversation
…ial mocks getIntegrationCredentialOrNull checks process.env before the DB mock. If GITHUB_TOKEN_IMPLEMENTER is set in the environment, it bypasses the mock and causes the credential resolver tests to fail. Use vi.stubEnv to set the vars to empty string (falsy) so the mock controls the result. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
🔍 Reviewing PR... |
nhopeatall
approved these changes
Feb 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean implementation that correctly mirrors the existing readyToProcessLabel union pattern for issueTransitioned. Schema default change (from z.boolean().default(true) to .optional()) is safe because both resolveJiraTriggerEnabled and resolveIssueTransitionedEnabled return true for undefined, preserving backward compatibility. The matches()/handle() split (any-agent check vs per-agent check) is consistent with the label-added trigger. CLI follows the review-trigger-set pattern. Dashboard mapping uses the existing dot-notation support. The projects.test.ts env-stubbing additions are a sensible drive-by fix.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
issueTransitionednow supports both legacy boolean and a per-agent object ({ briefing, planning, implementation }) following the same union pattern asreadyToProcessLabelresolveIssueTransitionedEnabledhelper — resolves per-agent toggle with backward-compatible boolean fallbackagentTypeinhandle();matches()continues using the "any agent enabled" check viaresolveJiraTriggerEnabledSHARED_PM_TRIGGERS; addedissueTransitioned.briefing/planning/implementationto each agent inAGENT_TRIGGER_MAP(dot-notation already supported by existingTriggerTogglescomponent)cascade projects pm-trigger-setfor managing Trello card-moved and JIRA issue-transitioned toggles per agent, following thereview-trigger-setpatternpm-trigger-setCLI commandTest plan
npm test -- tests/unit/config/triggerConfig.test.ts tests/unit/triggers/jira-issue-transitioned.test.ts— all 77 tests passnpm run typecheck— zero errorsnpm run lint— zero errorscascade projects pm-trigger-set <project-id> --no-issue-transitioned-implementationdisables the implementation agent's JIRA trigger without affecting briefing/planningcascade projects pm-trigger-set <project-id> --no-card-moved-to-briefingdisables Trello card-moved for briefingCard
https://trello.com/c/NLf1EhY5/85-briefing-planning-and-implementation-should-have-optional-toggles-exposed-in-dashboard-and-cli-for-triggering-on-moving-the-work
🤖 Generated with Claude Code