feat(pm): replace PR comment links with native attachments/remote links#498
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 23, 2026
Merged
feat(pm): replace PR comment links with native attachments/remote links#498zbigniewsobiecki merged 1 commit intodevfrom
zbigniewsobiecki merged 1 commit intodevfrom
Conversation
Collaborator
|
🔍 Reviewing PR... |
nhopeatall
approved these changes
Feb 23, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean abstraction that replaces comment-based PR links with native provider attachments/remote links, with a well-designed comment fallback.
The implementation is correct:
linkPRadded toPMProviderinterface with both adapters implementing it appropriately (JIRA → remote links, Trello → URL attachments)- JIRA leverages
createOrUpdateRemoteIssueLinkwithglobalId = prUrlfor idempotency — nice touch - Fallback logic correctly handles: linkPR failure → comment with/without progressCommentId → addComment as last resort
extractPRTitleis simple and handles edge cases (trailing paths, non-GitHub URLs)- Test coverage is thorough across all paths including cascading failures
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR created: <url>comment is posted only iflinkPRfailslinkPRabstraction added toPMProviderinterface so each provider uses its optimal APIaddRemoteLink— Leverages jira.js v5'sissueRemoteLinks.createOrUpdateRemoteIssueLink()with PR URL asglobalIdfor idempotencyCard: https://trello.com/c/ZceuaSMm/84-lets-research-and-plan-how-we-can-cleanly-attach-pr-links-probably-as-attachments-to-trello-cards-jira-issues-when-creating-a-pr
Test plan
linkPRcalled on implementation success with prUrllinkPRnot called when no prUrl or for non-implementation agentslinkPRsuccess → no comment postedlinkPRfailure → comment fallback fires (with and without progressCommentId)addRemoteLinkcalls jira.js with correct params (globalId = PR URL, relationship = "Pull Request", GitHub favicon icon)linkPRdelegates totrelloClient.addAttachmentlinkPRdelegates tojiraClient.addRemoteLink🤖 Generated with Claude Code