Skip to content

fix(triggers): skip self-authored PRs in pr-opened trigger#511

Merged
zbigniewsobiecki merged 1 commit intodevfrom
fix/skip-self-authored-pr-opened
Feb 23, 2026
Merged

fix(triggers): skip self-authored PRs in pr-opened trigger#511
zbigniewsobiecki merged 1 commit intodevfrom
fix/skip-self-authored-pr-opened

Conversation

@zbigniewsobiecki
Copy link
Copy Markdown
Member

Summary

  • Add persona check to pr-opened trigger so PRs authored by CASCADE bots are silently skipped — eliminates the spurious respond-to-review firing and ack comments seen in PR refactor: unify duplicated agent execution lifecycles into shared pipeline #509
  • Gracefully degrades when personaIdentities is unavailable (credential resolution failure) — trigger proceeds as before
  • Follows the same pattern used by check-suite-success and pr-comment-mention triggers

Test plan

  • Unit tests: implementer persona, reviewer persona, [bot] variant all return null
  • Unit tests: external PRs still fire normally with personaIdentities present
  • Unit tests: graceful degradation — fires normally without personaIdentities
  • Full trigger test suite passes (379 tests, 25 files)
  • Full project test suite passes (2800 tests, 168 files)
  • Lint and typecheck clean

🤖 Generated with Claude Code

The pr-opened trigger was firing respond-to-review on PRs created by
CASCADE's own implementer bot, generating spurious ack comments. Add
persona check (matching check-suite-success and pr-comment-mention
patterns) to return null for bot-authored PRs. Gracefully degrades
when personaIdentities is unavailable.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aaight
Copy link
Copy Markdown
Collaborator

aaight commented Feb 23, 2026

🤔 Just a sec, looking into that PR trigger fix now

@zbigniewsobiecki zbigniewsobiecki merged commit fe995f6 into dev Feb 23, 2026
1 check passed
@zbigniewsobiecki zbigniewsobiecki deleted the fix/skip-self-authored-pr-opened branch February 23, 2026 17:18
@aaight
Copy link
Copy Markdown
Collaborator

aaight commented Feb 23, 2026

This PR has already been closed. The comment you're seeing is the automated acknowledgment that CASCADE posted when the PR was initially opened. No further action is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants