fix(triggers): wrap manual-run agents with PM context#519
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 24, 2026
Merged
fix(triggers): wrap manual-run agents with PM context#519zbigniewsobiecki merged 1 commit intodevfrom
zbigniewsobiecki merged 1 commit intodevfrom
Conversation
Manual and retry runs called runAgent() directly without establishing AsyncLocalStorage-based PM context, causing agents (especially review) to crash with "No PMProvider in scope". Webhook-triggered agents already had this wrapping via withPMCredentials() + withPMProvider(). Wrap the runAgent() call in triggerManualRun() with the same PM context pattern used by the GitHub webhook handler. withPMCredentials gracefully falls through when no PM integration is configured. Closes #518 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
🤔 Just a sec, looking into that PR for you |
Collaborator
|
✅ All changes are committed and pushed. The fix wraps manual-run agents with PM context (matching the webhook-triggered pattern) to prevent Status:
The PR is ready for review once CI completes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"No PMProvider in scope"by wrappingrunAgent()inwithPMCredentials()+withPMProvider(), matching the pattern already used by webhook-triggered agentswithPMCredentialsgracefully falls through when no PM integration is configured, so projects without PM are unaffectedRoot cause
After PR #517 made
triggerManualRun()properlyawaitthe agent, the review agent now runs to completion inside the manual-run codepath. But that codepath never established the AsyncLocalStorage-based PM context that agents expect — webhook handlers do this viawithPMCredentials()+withPMProvider()(seesrc/triggers/github/webhook-handler.ts:111-123), but the manual-run path calledrunAgent()directly.Test plan
createPMProvider,withPMCredentials, andwithPMProviderare called with correct args🤖 Generated with Claude Code