fix(progress): retry once on empty progress model output#521
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 24, 2026
Merged
fix(progress): retry once on empty progress model output#521zbigniewsobiecki merged 1 commit intodevfrom
zbigniewsobiecki merged 1 commit intodevfrom
Conversation
Gemini Flash Lite via OpenRouter intermittently returns streaming responses with zero text content (~40% failure rate in production). Add a single retry with 1s delay in callProgressModelOnce() so the first empty response no longer immediately falls back to the generic template. Only the failure path adds latency. Update existing empty-output tests to expect both attempts to fail before throwing. Add two new tests verifying retry-then-success for both empty-text and no-events scenarios. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
🤔 Just a sec, looking into that retry logic for the progress model |
Collaborator
|
Thanks for taking a look! Let me know if you have any questions about the retry implementation or test coverage. The CI checks are currently running - lint-and-test should complete shortly. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callProgressModelOnce()for intermittent empty responses from Gemini Flash Lite via OpenRouter (~40% failure rate in production logs)Test plan
npm run lint— cleannpm run typecheck— cleannpm test -- tests/unit/backends/progressModel.test.ts— 11/11 passProgress model failedrate reduction🤖 Generated with Claude Code