feat(agents): rename briefing agent to splitting#541
Conversation
|
🔍 Reviewing code — Examining the PR changes for quality and correctness... Progress: [███░░░░░░░] 31% (iteration 22/70) 🔍 Code Review Update (1 min) I've completed a thorough review of the codebase, focusing on the Last updated: iteration 22 · review |
nhopeatall
left a comment
There was a problem hiding this comment.
Summary
Clean mechanical rename from briefing to splitting across ~78 files. The rename is thorough and consistent — no remaining briefing references in source, tests, web, or config (only in old migration files and the new migration SQL, as expected). CI passes. Migration SQL is well-structured and covers all JSONB paths.
Should Fix
- tools/run-local.ts:6 — Usage comment still says
briefinginstead ofsplitting. TheVALID_AGENTSarray was correctly updated but the doc comment on line 6 was missed. - tests/unit/router/ackMessageGenerator.test.ts:35-36 — The mock
INITIAL_MESSAGES.splittingstill uses the old message text ("Analyzing brief — Reading the card and gathering context to create a clear brief...") instead of the new text ("Splitting plan — Reading the plan and splitting it into ordered work items..."). The test passes because it asserts against its own mock, but the mock is misleading and won't catch regressions if the fallback logic changes. - src/db/migrations/meta/_journal.json — Lost trailing newline (minor).
|
@aaight address code review concerns |
Request AddressedWhat was askedAddress code review concerns from @nhopeatall's approved review. Changes Made
Verification
|
- Update usage comment in tools/run-local.ts to say 'splitting' instead of 'briefing' - Fix mock INITIAL_MESSAGES.splitting text in ackMessageGenerator test to match actual message - Restore trailing newline in _journal.json Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Addressed all three review concerns from @nhopeatall:
All 3226 tests pass, typecheck clean, lint clean (only pre-existing complexity warning). |
|
✨ On it — checking the branch rename Progress: [███░░░░░░░] 27% (iteration 19/70) 🔍 Code Review Update (1 min) I've completed a thorough review of the Last updated: iteration 19 · review |
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — Clean mechanical rename of "briefing" → "splitting" across 78 files.
Verified:
- No stale references: Zero remaining
briefingoccurrences outside of historical migration files (0001, 0005) and the new migration itself (0015) — all correct. - Migration SQL: All 5 JSONB update steps are correct. The
triggers - 'key' || jsonb_build_object(...)pattern correctly reads the old value before removing it (PostgreSQL evaluates SET expressions against original row values). Thejsonb_set+#-pattern for nested keys (issueTransitioned, readyToProcessLabel, statuses) is also correct. - Journal entry: Sequential
idx: 14, monotonically increasingwhentimestamp, tag matches filename. - Template rename:
briefing.eta→splitting.etaconfirmed on disk;briefing.etano longer exists. - Export rename:
BRIEFING_SYSTEM_PROMPT→SPLITTING_SYSTEM_PROMPT— consumers updated. - CI: All 3226 tests pass, typecheck clean, lint clean.
Summary
Renames the "briefing" agent to "splitting" across the entire codebase (~80 files). The splitting agent takes a prepared plan (output of the "planning" agent) and splits it into smaller, ordered work items.
briefing.etaprompt template tosplitting.etacardMovedToBriefing→cardMovedToSplitting, etc.)0015_rename_briefing_to_splitting.sqlfor clean-break data migrationBreaking change: Existing project configs must be updated via the DB migration. No backward compatibility — old
briefingdata will be updated tosplitting.Test plan
briefingreferencesNotes
Card: https://trello.com/c/Xp3hNwhd/113-rename-briefing-agent-to-splitting-focus-on-splitting-prepared-plans-into-ordered-work-items
🤖 Generated with Claude Code