Skip to content

feat(agents): rename briefing agent to splitting#541

Merged
zbigniewsobiecki merged 2 commits intodevfrom
feature/rename-briefing-to-splitting
Feb 24, 2026
Merged

feat(agents): rename briefing agent to splitting#541
zbigniewsobiecki merged 2 commits intodevfrom
feature/rename-briefing-to-splitting

Conversation

@aaight
Copy link
Copy Markdown
Collaborator

@aaight aaight commented Feb 24, 2026

Summary

Renames the "briefing" agent to "splitting" across the entire codebase (~80 files). The splitting agent takes a prepared plan (output of the "planning" agent) and splits it into smaller, ordered work items.

  • Renamed briefing.eta prompt template to splitting.eta
  • Updated all agent type registrations, capabilities, profiles, messages, and configs
  • Updated Trello/JIRA trigger config schemas (cardMovedToBriefingcardMovedToSplitting, etc.)
  • Updated all trigger handlers (Trello card-moved, JIRA issue-transitioned, label-added)
  • Updated GitHub persona map, router helpers, CLI flags, and web dashboard components
  • Created DB migration 0015_rename_briefing_to_splitting.sql for clean-break data migration
  • Updated CLAUDE.md and README.md documentation
  • Updated all 47 test files

Breaking change: Existing project configs must be updated via the DB migration. No backward compatibility — old briefing data will be updated to splitting.

Test plan

  • All 3226 unit tests pass
  • TypeScript type checking passes (zero errors)
  • Lint passes (only pre-existing complexity warning in adapter.ts)
  • DB migration SQL reviewed for correctness
  • All source files, web files, and test files verified to have no remaining briefing references

Notes

Card: https://trello.com/c/Xp3hNwhd/113-rename-briefing-agent-to-splitting-focus-on-splitting-prepared-plans-into-ordered-work-items

🤖 Generated with Claude Code

@nhopeatall
Copy link
Copy Markdown
Collaborator

nhopeatall commented Feb 24, 2026

🔍 Reviewing code — Examining the PR changes for quality and correctness...


Progress: [███░░░░░░░] 31% (iteration 22/70)

🔍 Code Review Update (1 min)

I've completed a thorough review of the codebase, focusing on the briefing to splitting rename. I've confirmed that most references have been updated correctly, with only expected instances remaining in migration files. I've identified a minor oversight in tools/run-local.ts where a usage comment still refers to briefing, and a more significant issue in tests/unit/router/ackMessageGenerator.test.ts where a mock's message content still uses the old term. I'm currently examining the migration SQL for potential null issues and will address the identified test and comment discrepancies next.

Last updated: iteration 22 · review

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Clean mechanical rename from briefing to splitting across ~78 files. The rename is thorough and consistent — no remaining briefing references in source, tests, web, or config (only in old migration files and the new migration SQL, as expected). CI passes. Migration SQL is well-structured and covers all JSONB paths.

Should Fix

  • tools/run-local.ts:6 — Usage comment still says briefing instead of splitting. The VALID_AGENTS array was correctly updated but the doc comment on line 6 was missed.
  • tests/unit/router/ackMessageGenerator.test.ts:35-36 — The mock INITIAL_MESSAGES.splitting still uses the old message text ("Analyzing brief — Reading the card and gathering context to create a clear brief...") instead of the new text ("Splitting plan — Reading the plan and splitting it into ordered work items..."). The test passes because it asserts against its own mock, but the mock is misleading and won't catch regressions if the fallback logic changes.
  • src/db/migrations/meta/_journal.json — Lost trailing newline (minor).

@zbigniewsobiecki
Copy link
Copy Markdown
Member

@aaight address code review concerns

@aaight
Copy link
Copy Markdown
Collaborator Author

aaight commented Feb 24, 2026

Request Addressed

What was asked

Address code review concerns from @nhopeatall's approved review.

Changes Made

  • tools/run-local.ts:6 — Updated usage comment from briefing to splitting
  • tests/unit/router/ackMessageGenerator.test.ts — Fixed mock INITIAL_MESSAGES.splitting to use the new message text, and updated the corresponding assertion
  • src/db/migrations/meta/_journal.json — Restored trailing newline

Verification

  • All 3226 tests passing ✅
  • TypeScript type checking passes (zero errors) ✅
  • Lint passes (only pre-existing complexity warning in adapter.ts) ✅

- Update usage comment in tools/run-local.ts to say 'splitting' instead of 'briefing'
- Fix mock INITIAL_MESSAGES.splitting text in ackMessageGenerator test to match actual message
- Restore trailing newline in _journal.json

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@aaight
Copy link
Copy Markdown
Collaborator Author

aaight commented Feb 24, 2026

Addressed all three review concerns from @nhopeatall:

  1. tools/run-local.ts:6 — Updated usage comment from briefing to splitting
  2. tests/unit/router/ackMessageGenerator.test.ts:35-36 — Fixed the mock INITIAL_MESSAGES.splitting text to use the new message ("Splitting plan — Reading the plan and splitting it into ordered work items...") instead of the old one. Also updated the corresponding assertion on line 325.
  3. src/db/migrations/meta/_journal.json — Restored trailing newline

All 3226 tests pass, typecheck clean, lint clean (only pre-existing complexity warning).

@nhopeatall
Copy link
Copy Markdown
Collaborator

nhopeatall commented Feb 24, 2026

✨ On it — checking the branch rename


Progress: [███░░░░░░░] 27% (iteration 19/70)

🔍 Code Review Update (1 min)

I've completed a thorough review of the briefing to splitting rename, confirming that splitting.eta exists and briefing.eta does not. I've also verified that Zod schemas, the web library, and the config schema correctly reference splitting. My checks of the Drizzle schema and the migration journal entry confirm the rename is complete and the migration is correctly recorded.

Last updated: iteration 19 · review

Copy link
Copy Markdown
Collaborator

@nhopeatall nhopeatall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — Clean mechanical rename of "briefing" → "splitting" across 78 files.

Verified:

  • No stale references: Zero remaining briefing occurrences outside of historical migration files (0001, 0005) and the new migration itself (0015) — all correct.
  • Migration SQL: All 5 JSONB update steps are correct. The triggers - 'key' || jsonb_build_object(...) pattern correctly reads the old value before removing it (PostgreSQL evaluates SET expressions against original row values). The jsonb_set + #- pattern for nested keys (issueTransitioned, readyToProcessLabel, statuses) is also correct.
  • Journal entry: Sequential idx: 14, monotonically increasing when timestamp, tag matches filename.
  • Template rename: briefing.etasplitting.eta confirmed on disk; briefing.eta no longer exists.
  • Export rename: BRIEFING_SYSTEM_PROMPTSPLITTING_SYSTEM_PROMPT — consumers updated.
  • CI: All 3226 tests pass, typecheck clean, lint clean.

@zbigniewsobiecki zbigniewsobiecki merged commit dc43a83 into dev Feb 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants