refactor(agents): remove dead legacy agent execution path (~2,100 lines)#543
Merged
zbigniewsobiecki merged 1 commit intodevfrom Feb 25, 2026
Merged
Conversation
Collaborator
|
🤖 Just a sec, looking into that refactor for the legacy agent execution path |
nhopeatall
approved these changes
Feb 24, 2026
Collaborator
nhopeatall
left a comment
There was a problem hiding this comment.
LGTM — clean dead code removal. All deleted symbols (executeAgent, AgentContext, AgentRunner, executeAgentLifecycle, injectDirectoryListing, injectContextFiles, injectSquintContext, fetchImplementationSteps, and the four per-agent execution files) have zero remaining references in the codebase. The FileLogger type import fix in cleanup.ts and runTracking.ts correctly points to the canonical export in executionPipeline.ts. The sole surviving export from syntheticCalls.ts (injectSyntheticCall) is confirmed used by the live backends/llmist/index.ts. CI passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes ~2,100 lines of dead legacy agent execution code that was left over after the codebase migrated to the unified backend adapter architecture (
backends/adapter.ts→agent-profiles.ts).respond-to-ci.ts,review.ts,respond-to-pr-comment.ts,respond-to-review.tslifecycle.ts,githubAgent.ts,prResponseAgent.ts,workItemBuilder.ts,workItemContext.tsbase.ts(executeAgent,AgentContext,AgentRunnerwere all unreachable)agents/index.ts— removes re-export of deletedexecuteAgent/AgentContext/AgentRunnersyntheticCalls.ts(injectDirectoryListing,injectContextFiles,injectSquintContext) — onlyinjectSyntheticCallremains (used by livebackends/llmist/index.ts)FileLoggertype imports incleanup.tsandrunTracking.ts(were importing from deletedlifecycle.ts, now import from liveexecutionPipeline.ts)syntheticCalls.test.tsto match remaining surfaceTest plan
npm run typecheck— zero errorsnpm test -- --run— 187 test files, 3190 tests, all passingnpm run lint— zero errors (1 pre-existing complexity warning unrelated to this change)🤖 Generated with Claude Code
Card: https://trello.com/c/c4d69Z1c/115-find-top-candidate-for-refactoring-and-plan-clean-refactoring-of-it-look-for-god-classes-modules-functions-files-code-duplicatio